Refactor and update naming guidance#1694
Merged
lmolkova merged 6 commits intoopen-telemetry:mainfrom Dec 19, 2024
Merged
Conversation
lmolkova
commented
Dec 18, 2024
lmolkova
commented
Dec 18, 2024
lmolkova
commented
Dec 18, 2024
lmolkova
commented
Dec 18, 2024
lmolkova
commented
Dec 18, 2024
trask
approved these changes
Dec 18, 2024
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
jsuereth
approved these changes
Dec 18, 2024
Merged
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates naming guidance based on small discussions and decisions made over the time.
In particular:
.instead of_whenever it makes sense (see Code generation: how to avoid naming collisions #1118 (comment))*.system.nameinstead of*.system- [DO NOT MERGE] Renamedb|messaging|gen_ai.systemto*.provider.name,rpc.systemtorpc.protocol.name#1613,deployment.environment->deployment.environment.name[cicd] add initial cicd attributes to registry #1075)vcs.repository.change.id->vcs.change.id- Add VCS metrics from Github receiver #1383)container.csi- container: add CSI attributes #1337 (comment))Merge requirement checklist
[chore]